Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate tarball extraction risks in test_download_model_with_test_data #6145

Closed
wants to merge 13 commits into from
Closed

Mitigate tarball extraction risks in test_download_model_with_test_data #6145

wants to merge 13 commits into from

Conversation

sunflowersxu
Copy link
Contributor

Description

Hello there, I submitted a change to test_download_model_with_test_data function in hub module to prevent potential path traversal attacks when user trying to download test data from a malicious repo.

Motivation and Context

In

onnx/onnx/hub.py

Line 369 in 4128a09

model_with_data_zipped.extractall(local_model_with_data_dir_path)

A tarball in third party repo can be downloaded and extracted without sanitized which may cause arbitrary file overwrite.
This patch will detect files which contain path traversal sequences and symbolic links in Tarball before extracting to file system and throw an exception to prevent path traversal attacks and symlink attacks.

Reference

https://huntr.com/bounties/5d7e5752-085c-4e93-af0d-e25f05a27b89

@sunflowersxu sunflowersxu requested a review from a team as a code owner May 23, 2024 02:25
@sunflowersxu
Copy link
Contributor Author

Hello, can anyone check this out? This is potential vulnerability.

@justinchuby
Copy link
Contributor

cc @gramalingam @liqunfu @ramkrishna2910 for thoughts

xadupre
xadupre reviewed May 27, 2024
View reviewed changes
onnx/hub.py Outdated Show resolved Hide resolved
xadupre
xadupre reviewed May 27, 2024
View reviewed changes
onnx/test/hub_test.py Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2024
View reviewed changes
onnx/test/hub_test.py Fixed Show fixed Hide fixed
onnx/hub.py Fixed Show fixed Hide fixed
onnx/hub.py Fixed Show fixed Hide fixed
onnx/test/hub_test.py Fixed Show fixed Hide fixed
@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 57.01%. Comparing base (83194ed) to head (1d0463a).
Report is 38 commits behind head on main.

❗ Current head 1d0463a differs from pull request most recent head 4ab7e71

Please upload reports for the commit 4ab7e71 to get more accurate results.

Files Patch % Lines
onnx/hub.py 6.66% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6145      +/-   ##
==========================================
+ Coverage   56.95%   57.01%   +0.06%     
==========================================
  Files         506      506              
  Lines       30467    30955     +488     
  Branches     4592     4599       +7     
==========================================
+ Hits        17353    17650     +297     
- Misses      12285    12478     +193     
+ Partials      829      827       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2024
View reviewed changes
onnx/hub.py Fixed Show fixed Hide fixed
sunflowersxu
sunflowersxu commented May 27, 2024
View reviewed changes
Copy link
Contributor Author

@sunflowersxu sunflowersxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space and reconstruct members_filter function for compatibility

justinchuby
justinchuby requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! My main concern is the completeness of this fix since I am no expert in this topic. May be worth for us the check with a security champ. Blocking for now.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2024
View reviewed changes
onnx/hub.py Fixed Show resolved Hide resolved
@sunflowersxu @sunriseXu
Fix tarball extraction in test_download_model_with_test_data with thi…
8617e62 
…rd party repo models

Signed-off-by: sunrise <1159309551xcz@gmail.com>
Signed-off-by: sunriseXu <15927176697@163.com>
@sunflowersxu @sunriseXu
remove space
e11ed63 
Signed-off-by: sunrise <1159309551xcz@gmail.com>
Signed-off-by: sunriseXu <15927176697@163.com>
@sunflowersxu @sunriseXu
Fix tarball extraction in test_download_model_with_test_data
5a8fbd8 
Signed-off-by: sunrise <1159309551xcz@gmail.com>
Signed-off-by: sunriseXu <15927176697@163.com>
@sunflowersxu @sunriseXu
fix coding styles with lintrunner
f86b002 
Signed-off-by: sunriseXu <15927176697@163.com>
justinchuby
justinchuby reviewed May 28, 2024
View reviewed changes
onnx/test/hub_test.py Outdated Show resolved Hide resolved
@sunflowersxu @sunriseXu
Avoid dependency on external files in tests, remove test of downloadi…
5b5a08b 
…ng model from external repo

Signed-off-by: sunriseXu <15927176697@163.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems May 29, 2024
View reviewed changes
onnx/hub.py Fixed Show fixed Hide fixed
@justinchuby justinchuby changed the title Fix tarball extraction in test_download_model_with_test_data Mitigate tarball extraction risks in test_download_model_with_test_data May 29, 2024
justinchuby
justinchuby reviewed May 29, 2024
View reviewed changes
onnx/hub.py Outdated Show resolved Hide resolved
onnx/hub.py Outdated Show resolved Hide resolved
onnx/hub.py Outdated Show resolved Hide resolved
onnx/hub.py Outdated Show resolved Hide resolved
@justinchuby justinchuby self-assigned this May 29, 2024
@justinchuby justinchuby added the better engineering Improve engineering quality of the project label May 29, 2024
@sunriseXu
Mitigate tarball extraction risks in test_download_model_with_test_data
37d6032 
Signed-off-by: sunriseXu <15927176697@163.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 1, 2024
View reviewed changes
onnx/hub.py
Comment on lines +408 to +411
members=_tar_members_filter(
model_with_data_zipped, local_model_with_data_dir_path
),

Check failure

Code scanning / CodeQL

Arbitrary file write during tarfile extraction

This file extraction depends on a [potentially untrusted source](1). This file extraction depends on a [potentially untrusted source](1).
@sunflowersxu
Copy link
Contributor Author

Hi, @justinchuby, is there any improvement I can do on this patch?

justinchuby
justinchuby reviewed Jun 3, 2024
View reviewed changes
onnx/hub.py Outdated Show resolved Hide resolved
justinchuby
justinchuby approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@sunflowersxu
Copy link
Contributor Author

Hi, @justinchuby , I noticed the merging is still blocking, is this because of the failed CodeQL scanning check? The last commit has patched the vulnerability, so this is a false positive.

@justinchuby justinchuby closed this Jun 4, 2024
@justinchuby justinchuby reopened this Jun 4, 2024
@justinchuby
Copy link
Contributor

The DCO check status is missing. Was all commits signed-off? Could you rebase on main?

@sunriseXu sunriseXu force-pushed the tarballfix branch 2 times, most recently from a27e69d to 2f947e4 Compare June 5, 2024 01:52
liqunfu and others added 6 commits June 5, 2024 02:23
@liqunfu @sunriseXu
Pin onnxruntime to 1.17.3 for release CIs (onnx#6143)
c1770b7 
The latest ORT 1.18.0 does not implement ML ops required for
test_backend_onnxruntime.py. Pin to the previous ort release to pass the
release CIs.

onnx#6138 (comment)

---------

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@dependabot @sunriseXu
Bump github/codeql-action from 2.13.4 to 3.25.7 (onnx#6156)
13bed2a 
Bumps [github/codeql-action](https://github.com/github/codeql-action)
from 2.13.4 to 3.25.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/github/codeql-action/releases">github/codeql-action's
releases</a>.</em></p>
<blockquote>
<h2>CodeQL Bundle v2.17.4</h2>
<p>Bundles CodeQL CLI v2.17.4</p>
<ul>
<li>(<a
href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.17.4">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4"><code>github/codeql@codeql-cli/v2.17.4</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/cpp/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/cpp/ql/src">source</a>)</li>
<li><code>codeql/cpp-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/cpp/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/cpp/ql/lib">source</a>)</li>
<li><code>codeql/csharp-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/csharp/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/csharp/ql/src">source</a>)</li>
<li><code>codeql/csharp-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/csharp/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/csharp/ql/lib">source</a>)</li>
<li><code>codeql/go-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/go/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/go/ql/src">source</a>)</li>
<li><code>codeql/go-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/go/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/go/ql/lib">source</a>)</li>
<li><code>codeql/java-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/java/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/java/ql/src">source</a>)</li>
<li><code>codeql/java-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/java/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/java/ql/lib">source</a>)</li>
<li><code>codeql/javascript-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/javascript/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/javascript/ql/src">source</a>)</li>
<li><code>codeql/javascript-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/javascript/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/javascript/ql/lib">source</a>)</li>
<li><code>codeql/python-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/python/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/python/ql/src">source</a>)</li>
<li><code>codeql/python-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/python/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/python/ql/lib">source</a>)</li>
<li><code>codeql/ruby-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/ruby/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/ruby/ql/src">source</a>)</li>
<li><code>codeql/ruby-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/ruby/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/ruby/ql/lib">source</a>)</li>
<li><code>codeql/swift-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/swift/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/swift/ql/src">source</a>)</li>
<li><code>codeql/swift-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/swift/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.4/swift/ql/lib">source</a>)</li>
</ul>
<h2>CodeQL Bundle v2.17.3</h2>
<p>Bundles CodeQL CLI v2.17.3</p>
<ul>
<li>(<a
href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.17.3">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3"><code>github/codeql@codeql-cli/v2.17.3</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/cpp/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/cpp/ql/src">source</a>)</li>
<li><code>codeql/cpp-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/cpp/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/cpp/ql/lib">source</a>)</li>
<li><code>codeql/csharp-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/csharp/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/csharp/ql/src">source</a>)</li>
<li><code>codeql/csharp-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/csharp/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/csharp/ql/lib">source</a>)</li>
<li><code>codeql/go-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/go/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/go/ql/src">source</a>)</li>
<li><code>codeql/go-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/go/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/go/ql/lib">source</a>)</li>
<li><code>codeql/java-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/java/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/java/ql/src">source</a>)</li>
<li><code>codeql/java-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/java/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/java/ql/lib">source</a>)</li>
<li><code>codeql/javascript-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/javascript/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/javascript/ql/src">source</a>)</li>
<li><code>codeql/javascript-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/javascript/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/javascript/ql/lib">source</a>)</li>
<li><code>codeql/python-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/python/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/python/ql/src">source</a>)</li>
<li><code>codeql/python-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/python/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/python/ql/lib">source</a>)</li>
<li><code>codeql/ruby-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/ruby/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/ruby/ql/src">source</a>)</li>
<li><code>codeql/ruby-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/ruby/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/ruby/ql/lib">source</a>)</li>
<li><code>codeql/swift-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/swift/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/swift/ql/src">source</a>)</li>
<li><code>codeql/swift-all</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/swift/ql/lib/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.3/swift/ql/lib">source</a>)</li>
</ul>
<h2>CodeQL Bundle v2.17.2</h2>
<p>Bundles CodeQL CLI v2.17.2</p>
<ul>
<li>(<a
href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.17.2">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.2"><code>github/codeql@codeql-cli/v2.17.2</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.2/cpp/ql/src/CHANGELOG.md">changelog</a>,
<a
href="https://github.com/github/codeql/tree/codeql-cli/v2.17.2/cpp/ql/src">source</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's
changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a
href="https://github.com/github/codeql-action/releases">releases
page</a> for the relevant changes to the CodeQL CLI and language
packs.</p>
<p>Note that the only difference between <code>v2</code> and
<code>v3</code> of the CodeQL Action is the node version they support,
with <code>v3</code> running on node 20 while we continue to release
<code>v2</code> to support running on node 16. For example
<code>3.22.11</code> was the first <code>v3</code> release and is
functionally identical to <code>2.22.11</code>. This approach ensures an
easy way to track exactly which features are included in different
versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.25.7 - 31 May 2024</h2>
<ul>
<li>We are rolling out a feature in May/June 2024 that will reduce the
Actions cache usage of the Action by keeping only the newest TRAP cache
for each language. <a
href="https://redirect.github.com/github/codeql-action/pull/2306">#2306</a></li>
</ul>
<h2>3.25.6 - 20 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.3. <a
href="https://redirect.github.com/github/codeql-action/pull/2295">#2295</a></li>
</ul>
<h2>3.25.5 - 13 May 2024</h2>
<ul>
<li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI,
and GitHub Enterprise Server versions to the <a
href="https://github.com/github/codeql-action/blob/main/README.md">https://github.com/github/codeql-action/blob/main/README.md</a>.
<a
href="https://redirect.github.com/github/codeql-action/pull/2273">#2273</a></li>
<li>Avoid printing out a warning for a missing <code>on.push</code>
trigger when the CodeQL Action is triggered via a
<code>workflow_call</code> event. <a
href="https://redirect.github.com/github/codeql-action/pull/2274">#2274</a></li>
<li>The <code>tools: latest</code> input to the <code>init</code> Action
has been renamed to <code>tools: linked</code>. This option specifies
that the Action should use the tools shipped at the same time as the
Action. The old name will continue to work for backwards compatibility,
but we recommend that new workflows use the new name. <a
href="https://redirect.github.com/github/codeql-action/pull/2281">#2281</a></li>
</ul>
<h2>3.25.4 - 08 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.2. <a
href="https://redirect.github.com/github/codeql-action/pull/2270">#2270</a></li>
</ul>
<h2>3.25.3 - 25 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.1. <a
href="https://redirect.github.com/github/codeql-action/pull/2247">#2247</a></li>
<li>Workflows running on <code>macos-latest</code> using CodeQL CLI
versions before v2.15.1 will need to either upgrade their CLI version to
v2.15.1 or newer, or change the platform to an Intel MacOS runner, such
as <code>macos-12</code>. ARM machines with SIP disabled, including the
newest <code>macos-latest</code> image, are unsupported for CLI versions
before 2.15.1. <a
href="https://redirect.github.com/github/codeql-action/pull/2261">#2261</a></li>
</ul>
<h2>3.25.2 - 22 Apr 2024</h2>
<p>No user facing changes.</p>
<h2>3.25.1 - 17 Apr 2024</h2>
<ul>
<li>We are rolling out a feature in April/May 2024 that improves the
reliability and performance of analyzing code when analyzing a compiled
language with the <code>autobuild</code> <a
href="https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes">build
mode</a>. <a
href="https://redirect.github.com/github/codeql-action/pull/2235">#2235</a></li>
<li>Fix a bug where the <code>init</code> Action would fail if
<code>--overwrite</code> was specified in
<code>CODEQL_ACTION_EXTRA_OPTIONS</code>. <a
href="https://redirect.github.com/github/codeql-action/pull/2245">#2245</a></li>
</ul>
<h2>3.25.0 - 15 Apr 2024</h2>
<ul>
<li>
<p>The deprecated feature for extracting dependencies for a Python
analysis has been removed. <a
href="https://redirect.github.com/github/codeql-action/pull/2224">#2224</a></p>
<p>As a result, the following inputs and environment variables are now
ignored:</p>
<ul>
<li>The <code>setup-python-dependencies</code> input to the
<code>init</code> Action</li>
<li>The
<code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION</code>
environment variable</li>
</ul>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/github/codeql-action/commit/f079b8493333aace61c81488f8bd40919487bd9f"><code>f079b84</code></a>
Merge pull request <a
href="https://redirect.github.com/github/codeql-action/issues/2317">#2317</a>
from github/update-v3.25.7-a095bf2a1</li>
<li><a
href="https://github.com/github/codeql-action/commit/e1a42688dbe6ce54cc33e2b6b65fc02abdb09762"><code>e1a4268</code></a>
Update changelog for v3.25.7</li>
<li><a
href="https://github.com/github/codeql-action/commit/a095bf2a16b83cb3b52e6adba696c70f41e82864"><code>a095bf2</code></a>
Merge pull request <a
href="https://redirect.github.com/github/codeql-action/issues/2313">#2313</a>
from github/revert-2312-update-bundle/codeql-bundle-...</li>
<li><a
href="https://github.com/github/codeql-action/commit/bbd4e19f51d83bb98b025b83b255e44eaa1a1e7f"><code>bbd4e19</code></a>
Revert &quot;Update default bundle to 2.17.4&quot;</li>
<li><a
href="https://github.com/github/codeql-action/commit/9ab5d16a3df4885b74bb18ab349bcc6c253ee3e0"><code>9ab5d16</code></a>
Merge pull request <a
href="https://redirect.github.com/github/codeql-action/issues/2312">#2312</a>
from github/update-bundle/codeql-bundle-v2.17.4</li>
<li><a
href="https://github.com/github/codeql-action/commit/028346e1ff2c03a735c6527b84f0a3179f2092b0"><code>028346e</code></a>
Add changelog note</li>
<li><a
href="https://github.com/github/codeql-action/commit/5fe08473f8b98c47563f401bed5134a59ce06dee"><code>5fe0847</code></a>
Update default bundle to codeql-bundle-v2.17.4</li>
<li><a
href="https://github.com/github/codeql-action/commit/9550da953dd3b29aedf76cd635101e48eae5eebd"><code>9550da9</code></a>
Merge pull request <a
href="https://redirect.github.com/github/codeql-action/issues/2311">#2311</a>
from github/henrymercer/pack-missing-auth-config-error</li>
<li><a
href="https://github.com/github/codeql-action/commit/6548a4d65ce2414afca98f8368cabfff0541ba18"><code>6548a4d</code></a>
Add configuration error for missing auth to package registry</li>
<li><a
href="https://github.com/github/codeql-action/commit/7927df07e268eafe499c344cd19f8bf82f4f19f7"><code>7927df0</code></a>
Bump micromatch from 4.0.5 to 4.0.7 in the npm group (<a
href="https://redirect.github.com/github/codeql-action/issues/2310">#2310</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/github/codeql-action/compare/cdcdbb579706841c47f7063dda365e292e5cad7a...f079b8493333aace61c81488f8bd40919487bd9f">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.13.4&new-version=3.25.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @sunriseXu
Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (onnx#6154)
d646a07 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action)
from 2.3.1 to 2.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's
releases</a>.</em></p>
<blockquote>
<h2>v2.3.3</h2>
<blockquote>
<p>[!NOTE]<br />
There is no v2.3.2 release as a step was skipped in the release process.
This was fixed and re-released under the v2.3.3 tag</p>
</blockquote>
<h2>What's Changed</h2>
<ul>
<li>:seedling: Bump github.com/ossf/scorecard/v4 (v4.13.1) to
github.com/ossf/scorecard/v5 (v5.0.0-rc1) by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://redirect.github.com/ossf/scorecard-action/pull/1366">ossf/scorecard-action#1366</a></li>
<li>:seedling: Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to
v5.0.0-rc2 by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://redirect.github.com/ossf/scorecard-action/pull/1374">ossf/scorecard-action#1374</a></li>
<li>:seedling: Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to
v5.0.0-rc2.0.20240509182734-7ce860946928 by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://redirect.github.com/ossf/scorecard-action/pull/1377">ossf/scorecard-action#1377</a></li>
</ul>
<p>For a full changelist of what these include, see the <a
href="https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc1">v5.0.0-rc1</a>
and <a
href="https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc2">v5.0.0-rc2</a>
release notes.</p>
<h3>Documentation</h3>
<ul>
<li>:book: Move token discussion out of main README. by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://redirect.github.com/ossf/scorecard-action/pull/1279">ossf/scorecard-action#1279</a></li>
<li>:book: link to <code>ossf/scorecard</code> workflow instead of
maintaining an example by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://redirect.github.com/ossf/scorecard-action/pull/1352">ossf/scorecard-action#1352</a></li>
<li>:book: update api links to new scorecard.dev site by <a
href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a>
in <a
href="https://redirect.github.com/ossf/scorecard-action/pull/1376">ossf/scorecard-action#1376</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.3">https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/ossf/scorecard-action/commit/dc50aa9510b46c811795eb24b2f1ba02a914e534"><code>dc50aa9</code></a>
:seedling: Bump docker tag for v2.3.3 release (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1368">#1368</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/8ff570017382a0ef795f21f71e519b27a9b5f29e"><code>8ff5700</code></a>
:seedling: Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to
v5.0.0-rc2.0....</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/8ba5e73d11a5fd0917494d02ab01dfd7866d2191"><code>8ba5e73</code></a>
update api links to new scorecard.dev site (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1376">#1376</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/92ddde3eaffd7e147638317c023642a6adc8a874"><code>92ddde3</code></a>
Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to v5.0.0-rc2 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1374">#1374</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/6c55905542a1ce814c7ec177a96904f5bc74aab5"><code>6c55905</code></a>
:seedling: Bump golang.org/x/net from 0.24.0 to 0.25.0 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1373">#1373</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/09bb953b6a0e34c84fb453985435a07cc2baa3a3"><code>09bb953</code></a>
:seedling: Bump distroless/base in the docker-images group (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1372">#1372</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/1511e1305b9d7e51245388421563264573c77bc7"><code>1511e13</code></a>
:seedling: Bump the github-actions group across 1 directory with 6
updates (#...</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/df66cd8fd834fab4483ac0031b8d8ff819b62422"><code>df66cd8</code></a>
:seedling: Bump the docker-images group with 2 updates (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1370">#1370</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/fad9a3cc533bb069b1f01f272f1f630895cd690a"><code>fad9a3c</code></a>
:seedling: Bump distroless/base in the docker-images group (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1364">#1364</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/1e01a309c1de65b6221c25768bcfc322bac8ccee"><code>1e01a30</code></a>
:seedling: Bump the github-actions group with 3 updates (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1365">#1365</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/ossf/scorecard-action/compare/0864cf19026789058feabb7e87baa5f140aac736...dc50aa9510b46c811795eb24b2f1ba02a914e534">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.3.1&new-version=2.3.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sunriseXu
Mitigate tarball directory traversal risks
6dc2c06 
Signed-off-by: sunriseXu <15927176697@163.com>
@adrianlizarraga @dependabot @sunriseXu
Fix INT4 TensorProto byte size is 5x larger than expected with negati…
ccf8e69 
…ve values (onnx#6161)

Fixes onnx#6160

Ensures that two 4-bit elements are packed as a single [unsigned] uint8
value within the `int32_data` field. Otherwise, the size of an int4
tensor increases up 5x when the tensor contains negative data values.
Please refer to the above issue for more details.

Certain models with INT4 weights were much larger than expected.

---------

Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@adrianlizarraga @dependabot @sunriseXu
Fix INT4 TensorProto byte size is 5x larger than expected with negati…
bc43652 
…ve values (onnx#6161)

Fixes onnx#6160

Ensures that two 4-bit elements are packed as a single [unsigned] uint8
value within the `int32_data` field. Otherwise, the size of an int4
tensor increases up 5x when the tensor contains negative data values.
Please refer to the above issue for more details.

Certain models with INT4 weights were much larger than expected.

---------

Signed-off-by: adrianlizarraga <adlizarraga@microsoft.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sunflowersxu @sunriseXu
Merge branch 'main' into tarballfix
4ab7e71 
Signed-off-by: sunriseXu <15927176697@163.com>
@sunflowersxu sunflowersxu mentioned this pull request Jun 6, 2024
Merged
@sunflowersxu
Copy link
Contributor Author

Hi, @justinchuby @xadupre, this pr is a bit of mess, I have create new one #6164 , this pr can be closed

@justinchuby justinchuby closed this Jun 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2024
@sunflowersxu @sunriseXu @justinchuby
Mitigate tarball directory traversal risks (#6164)
3fc3845 
Hi, this pr is cleaner version than #6145

Signed-off-by: sunriseXu <15927176697@163.com>
Co-authored-by: sunriseXu <15927176697@163.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@xadupre xadupre xadupre approved these changes

Assignees

@justinchuby justinchuby

Labels
better engineering Improve engineering quality of the project
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sunflowersxu @justinchuby @xadupre @sunriseXu @liqunfu @adrianlizarraga