Add alternative approach in ONNX converter section #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagoel4512
force-pushed
the
add-alternative-approach
branch
3 times, most recently
from
cc18dfe
to
ee93cb6
Compare
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512
force-pushed
the
add-alternative-approach
branch
from
ee93cb6
to
cba2a13
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6188 +/- ##
==========================================
+ Coverage 56.95% 57.02% +0.07%
==========================================
Files 506 506
Lines 30467 30955 +488
Branches 4592 4599 +7
==========================================
+ Hits 17353 17653 +300
- Misses 12285 12476 +191
+ Partials 829 826 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a short section explaining an alternative approach to dedicated converter libraries for library authors looking to implement ONNX export capability for their library. This approach leverages a standardised protocol (in this case the Array API standard) and an ONNX based implementation of it (in this case ndonnx).
Motivation and Context
This adds some broader context to the different ways libraries may want to explore ONNX export beyond the traditional approach with dedicated converter libraries.