Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong test name (causing test files of previous test with same name to be overwritten) #6189

Closed
wants to merge 1 commit into from

Conversation

rosemanmeilof
Copy link

Description

In test empty_axes_input_noop, correct the name of the name as passed on to expect function

Motivation and Context

The passed name was previously test_reduce_sum_negative_axes_keepdims_random, which clashed with an earlier test with the same name, causing test files to be overwritten

@rosemanmeilof rosemanmeilof requested a review from a team as a code owner June 18, 2024 13:35
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.09%. Comparing base (83194ed) to head (48011c8).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6189      +/-   ##
==========================================
+ Coverage   56.95%   57.09%   +0.14%     
==========================================
  Files         506      506              
  Lines       30467    30974     +507     
  Branches     4592     4603      +11     
==========================================
+ Hits        17353    17686     +333     
- Misses      12285    12464     +179     
+ Partials      829      824       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gramalingam
gramalingam previously approved these changes Jun 19, 2024
@gramalingam
Copy link
Contributor

Thanks for catching this. A couple of things are required:

The DCO needs to be signed.

The affected test-data needs to be generated and committed.

@xadupre
Copy link
Contributor

xadupre commented Jun 20, 2024

I'm closing this PR, I replaced it #6194 because this issue happens on some other test case. I added some logic to detect it does not happen again.

@xadupre xadupre closed this Jun 20, 2024
@rosemanmeilof
Copy link
Author

Great!

github-merge-queue bot pushed a commit that referenced this pull request Jun 20, 2024
…t happen again (#6194)

Replaces #6189 and checks this bug does not happen somewhere else.

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants