New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightGBM Tests #152
LightGBM Tests #152
Conversation
little-eyes
commented
Oct 18, 2018
- binary classification convert
- multiclass classification convert
- regression convert
Jilong Liao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
What is the difference with the tests implemented in https://github.com/onnx/onnxmltools/blob/master/tests/sklearn/test_TreeEnsembleConverters.py? |
Ah, I missed it. Also the multiclass LightGBM classification seems to have some issues. When I try to use it, i encountered into problems, that's why I want to add the multiclass test. Since I can't find a LightGBM test file, then I added one. |
So I changed the PR to just add the multiclass tests. Actually, the problem I saw does not repro anymore.. |
Any update of this PR, do we still need it? |
It should be not needed anymore. |