New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prroy/knnc #169
Merged
Merged
Prroy/knnc #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
reviewed
Nov 7, 2018
@prabhat00155, any unit test for this new converter? |
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
onnxmltools/convert/sklearn/operator_converters/OneHotEncoder.py
Outdated
Show resolved
Hide resolved
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 12, 2018
wschin
reviewed
Nov 13, 2018
wschin
reviewed
Nov 13, 2018
wschin
reviewed
Nov 13, 2018
wschin
reviewed
Nov 13, 2018
wschin
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for doing this great job.
wenbingl
approved these changes
Nov 13, 2018
wenbingl
pushed a commit
to wenbingl/onnxmltools
that referenced
this pull request
Nov 14, 2018
* Initial changes * Merged PCA with SVD and added KNN shape calculators in Linear * Merged KNN classifier and regressor files * Added Naive Bayes converters * Addressed PR comments about name changes, reverting to previous names * Removing extra import from init * Added LassoLars and Ridge converters * Fixed issues with running test on NB models * Added comments * Merged LeastSquares with LinearRegressor, added computational graph to NB, etc. * Fixed bug in KNN Classifier * Added calculation of probability to NB converter * Added unit tests * Addressed review comments * Removed duplicate function * Added comment to clarify two output paths * Removed non-ascii character * Fixed topk calculation error in KNNR * Fixed additional cases in PCA * Fixed cntk and scikit versions * Added KNN Classifier converter * Added KNN classifier tests * Fixed some NB issues * Updated computation graph and added runtime check in unit test * Updated computation graphs and KNN Classifier unit test * changed np to numpy * Addressed review comments * Addressed review comments
vinitra-zz
pushed a commit
to vinitra-zz/onnxmltools
that referenced
this pull request
Nov 17, 2018
* Initial changes * Merged PCA with SVD and added KNN shape calculators in Linear * Merged KNN classifier and regressor files * Added Naive Bayes converters * Addressed PR comments about name changes, reverting to previous names * Removing extra import from init * Added LassoLars and Ridge converters * Fixed issues with running test on NB models * Added comments * Merged LeastSquares with LinearRegressor, added computational graph to NB, etc. * Fixed bug in KNN Classifier * Added calculation of probability to NB converter * Added unit tests * Addressed review comments * Removed duplicate function * Added comment to clarify two output paths * Removed non-ascii character * Fixed topk calculation error in KNNR * Fixed additional cases in PCA * Fixed cntk and scikit versions * Added KNN Classifier converter * Added KNN classifier tests * Fixed some NB issues * Updated computation graph and added runtime check in unit test * Updated computation graphs and KNN Classifier unit test * changed np to numpy * Addressed review comments * Addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KNN Classifier converter