Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prroy/knnc #169

Merged
merged 32 commits into from Nov 14, 2018
Merged

Prroy/knnc #169

merged 32 commits into from Nov 14, 2018

Conversation

prabhat00155
Copy link
Collaborator

KNN Classifier converter

@wenbingl
Copy link
Member

wenbingl commented Nov 7, 2018

@prabhat00155, any unit test for this new converter?

Copy link
Contributor

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for doing this great job. :shipit:

@prabhat00155 prabhat00155 merged commit dbcf927 into onnx:master Nov 14, 2018
wenbingl pushed a commit to wenbingl/onnxmltools that referenced this pull request Nov 14, 2018
* Initial changes

* Merged PCA with SVD and added KNN shape calculators in Linear

* Merged KNN classifier and regressor files

* Added Naive Bayes converters

* Addressed PR comments about name changes, reverting to previous names

* Removing extra import from init

* Added LassoLars and Ridge converters

* Fixed issues with running test on NB models

* Added comments

* Merged LeastSquares with LinearRegressor, added computational graph to NB, etc.

* Fixed bug in KNN Classifier

* Added calculation of probability to NB converter

* Added unit tests

* Addressed review comments

* Removed duplicate function

* Added comment to clarify two output paths

* Removed non-ascii character

* Fixed topk calculation error in KNNR

* Fixed additional cases in PCA

* Fixed cntk and scikit versions

* Added KNN Classifier converter

* Added KNN classifier tests

* Fixed some NB issues

* Updated computation graph and added runtime check in unit test

* Updated computation graphs and KNN Classifier unit test

* changed np to numpy

* Addressed review comments

* Addressed review comments
vinitra-zz pushed a commit to vinitra-zz/onnxmltools that referenced this pull request Nov 17, 2018
* Initial changes

* Merged PCA with SVD and added KNN shape calculators in Linear

* Merged KNN classifier and regressor files

* Added Naive Bayes converters

* Addressed PR comments about name changes, reverting to previous names

* Removing extra import from init

* Added LassoLars and Ridge converters

* Fixed issues with running test on NB models

* Added comments

* Merged LeastSquares with LinearRegressor, added computational graph to NB, etc.

* Fixed bug in KNN Classifier

* Added calculation of probability to NB converter

* Added unit tests

* Addressed review comments

* Removed duplicate function

* Added comment to clarify two output paths

* Removed non-ascii character

* Fixed topk calculation error in KNNR

* Fixed additional cases in PCA

* Fixed cntk and scikit versions

* Added KNN Classifier converter

* Added KNN classifier tests

* Fixed some NB issues

* Updated computation graph and added runtime check in unit test

* Updated computation graphs and KNN Classifier unit test

* changed np to numpy

* Addressed review comments

* Addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants