Add Keras end-to-end tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wschin
commented
May 11, 2018
•
wschin
commented
- Add some basic end-to-end tests
- Fix batch normalization and dense layer conversions
- Remove redundant class in keras/_parser.py
- Sync Keras conversion function interface with CoreML's and scikit-learn's
- Fix keras==2.0.9 for CI tests
1. Add some basic end-to-end tests 2. Fix batch normalization and dense layer conversions 3. Remove redundant class in keras/_parser.py 4. Sync Keras conversion function interface with CoreML's and scikit-learn's
Our Keras parser has some issues around Sequential object. It looks like Sequential are different across different versions of Keras. Thus, we replace all Sequential objects with Model objects for now.
shauheen
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.