Fixes #396, xgboost converter for xgboost >= 1.0.2 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiafatom
reviewed
May 21, 2020
| @@ -12,5 +12,9 @@ def get_xgb_params(xgb_node): | |||
| else: | |||
| # XGBoost < 0.7 | |||
| params = xgb_node.__dict__ | |||
|
|
|||
|
|
|||
| if ('n_estimators' not in params and | |||
There was a problem hiding this comment.
I need to check because I'm not sure which versions of python support this. I use that because that's what's done in scikit-learn.
There was a problem hiding this comment.
It does not work without () for me.
There was a problem hiding this comment.
Is it due to parenthesis has to enclose the (not in)? not the full statement?
There was a problem hiding this comment.
The parenthesis are used to write the test over two lines, otherwise, I would have to use symbol . Apparently, if ( … \n ...): seems to be the preferred one.
wenbingl
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.