Add an example to create a custom converter for a NMF transformer #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhat00155
reviewed
Jun 7, 2019
| :math:`M=(m_{ij})` may be a binary matrix where *i* is a user | ||
| and *j* a product he bought. The prediction | ||
| function depends on whether or not the user needs an | ||
| recommandation for an existing user or a new user. |
There was a problem hiding this comment.
Typo here: "a recommendation"
There was a problem hiding this comment.
"recommandation" typo still there.
docs/examples/plot_nmf.py
Outdated
| from sklearn.decomposition import NMF | ||
| import numpy as np | ||
| import matplotlib.pyplot as plt | ||
| import os |
There was a problem hiding this comment.
This is a standard library import and should be placed before third-party imports. Sadly flake8 doesn't catch it, but you can run pylint locally on your code to see these violations.
There was a problem hiding this comment.
I don't see the change: import os should be at the very top.
prabhat00155
approved these changes
Jun 11, 2019
| :math:`M=(m_{ij})` may be a binary matrix where *i* is a user | ||
| and *j* a product he bought. The prediction | ||
| function depends on whether or not the user needs an | ||
| recommandation for an existing user or a new user. |
There was a problem hiding this comment.
"recommandation" typo still there.
docs/examples/plot_nmf.py
Outdated
| from sklearn.decomposition import NMF | ||
| import numpy as np | ||
| import matplotlib.pyplot as plt | ||
| import os |
There was a problem hiding this comment.
I don't see the change: import os should be at the very top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.