Improve OnnxOperator to support more types #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,14 +70,21 @@ def _add_constant(self, cst): | |||
| self.operator_name + 'cst') | |||
| if cst.dtype in (np.float32, np.float64): | |||
| ty = onnx_proto.TensorProto.FLOAT | |||
| astype = np.float64 | |||
| elif cst.dtype == np.int32: | |||
| ty = onnx_proto.TensorProto.INT32 | |||
There was a problem hiding this comment.
You are setting this to INT32 but typecasting to int64 in line 87. Is that what you intended to do, could you explain?
There was a problem hiding this comment.
Not sure if it is a bug or not but in onnx.helper.py, https://github.com/onnx/onnx/blob/master/onnx/helper.py#L231, the function check that number of float64 (not float32) so I'm just trying to avoid the exception at line https://github.com/onnx/onnx/blob/master/onnx/helper.py#L251.
prabhat00155
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.