Fixed gradient boosting converters for different values of init hyper… #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbingl
approved these changes
Jul 15, 2019
| else: | ||
| base_values = op.init_.priors | ||
| raise NotImplementedError( | ||
| 'Setting init to an estimator is not supported, you may raise an ' |
There was a problem hiding this comment.
If setting init is doable, probably you can add an issue by yourself and put the link the exception, is it better?
There was a problem hiding this comment.
It's not as straight-forward. If init is set to an estimator, we'll have to call it's predict(), which we could do but the result would be a set of output names(which will be evaluated by onnxruntime). However, TreeClassifier and TreeRegressor onnx ops expect a list of floats as base_values. This makes the implementation tricky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-parameter