GaussianProcessRegressor with float and double in ONNX models #220
Conversation
xadupre
changed the title
|
|
docs/examples/plot_gpr.py
Outdated
|
|
||
| import skl2onnx | ||
| import onnxruntime | ||
| import onnx |
There was a problem hiding this comment.
It would look better/more readable if we have these in alphabetical order and all sklearn imports clubbed together.
skl2onnx/_parse.py
Outdated
| this_operator.outputs.append(mean_tensor) | ||
|
|
||
| if options['return_std'] or options['return_cov']: | ||
| # covarance or standard deviation |
| @@ -0,0 +1,255 @@ | |||
| # ------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Please add unit tests for this file. Current coverage is 12%.
skl2onnx/operator_converters/_gp_kernels.py 121 107 12% 23-24, 28-61, 66-73, 78-88, 97-104, 113-121, 126-232, 238-255
There was a problem hiding this comment.
Unit tests do exists. They are just disabled since they cannot be run with the current runtime.
| @@ -0,0 +1,126 @@ | |||
| # ------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Could you add unit tests to improve coverage for this file? It's just 18%.
skl2onnx/operator_converters/gaussian_process.py 56 46 18% 15-16, 36-121
There was a problem hiding this comment.
Same answer as above.
No description provided.