More consistent opset accross converters and unit tests #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadupre
changed the title
|
Adresses #474. |
wenbingl
approved these changes
Jun 3, 2020
wenbingl
reviewed
Jun 3, 2020
skl2onnx/common/_container.py
Outdated
| @@ -60,7 +60,8 @@ def _get_operation_list(): | |||
| # does not follow the same schema | |||
| continue | |||
| if k in {'apply_less_or_equal', 'apply_greater_or_equal', | |||
| 'apply_relu6'}: | |||
| 'apply_relu6', 'apply_relu_6', 'apply_slice2', | |||
There was a problem hiding this comment.
so every changes on apply_functions will cause an update here?
There was a problem hiding this comment.
I added this test when these functions were part of skl2onnx to do basic verification on the function code. I should remove it. There is no unit test in onnxconverter-common so this was added to catch some common mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.