Skip to content

Commit

Permalink
Merge pull request #1141 from onnx/tom/ImproveLargeModelErrDetection
Browse files Browse the repository at this point in the history
Improved detection of conversion errors due to large models
  • Loading branch information
TomWildenhain-Microsoft committed Oct 19, 2020
2 parents 2c89c15 + 454c713 commit 4c94727
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tf2onnx/tf_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def _from_saved_model_v2(model_path, input_names, output_names, tag, signature_d
try:
frozen_graph = from_function(concrete_func, inputs, outputs, large_model)
except ValueError as e:
if "exceeds maximum protobuf size of 2GB" in str(e):
if any(msg in str(e) for msg in ["exceeds maximum protobuf size of 2GB", "string too long"]):
raise ValueError(err_large_model)
raise e

Expand Down

0 comments on commit 4c94727

Please sign in to comment.