Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSDMobilenet2ONNX Tutorial #842

Closed
rmccorm4 opened this issue Mar 16, 2020 · 4 comments
Closed

SSDMobilenet2ONNX Tutorial #842

rmccorm4 opened this issue Mar 16, 2020 · 4 comments

Comments

@rmccorm4
Copy link

Hi @guschmue ,

Was just glancing at https://github.com/onnx/tensorflow-onnx/blob/master/tutorials/ConvertingSSDMobilenetToONNX.ipynb, and had a quick question.

I noticed these lines in the first cell:

# force tf2onnx to cpu
os.environ['CUDA_VISIBLE_DEVICES'] = "0"

This line os.environ['CUDA_VISIBLE_DEVICES'] = "0" is actually specifying that CUDA applications will see/use only the first (zero-indexed) GPU on the system if any.

So the comment above that line is a bit misleading, and actually incorrect if you're expecting the CPU vs. GPU conversion to have different results, such as in this issue: #801 (comment)

Just wanted to point it out to avoid misleading people, unless I'm mistaken. 🙂

@guschmue
Copy link
Collaborator

oh, good catch! I wanted it to be "" and will fix it shortly.
For this specific tutorial it should not break something I think.

@guschmue
Copy link
Collaborator

should be fixed in master.

@rmccorm4
Copy link
Author

rmccorm4 commented Mar 19, 2020

Hi @guschmue ,

I see it's fixed in the efficientnet-lite tutorial, but still seems the same for the SSDMobilenet tutorial on master, that I originally brought up.

Looks like the latest commit for that tutorial was a no-op (just removed a new-line). Just mentioning in case it was accidentally missed.

Thanks,
Ryan

@guschmue
Copy link
Collaborator

Oh, sorry - I messed up. Let me try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants