Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved detection of conversion errors due to large models #1141

Merged
merged 1 commit into from
Oct 19, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tf2onnx/tf_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def _from_saved_model_v2(model_path, input_names, output_names, tag, signature_d
try:
frozen_graph = from_function(concrete_func, inputs, outputs, large_model)
except ValueError as e:
if "exceeds maximum protobuf size of 2GB" in str(e):
if any(msg in str(e) for msg in ["exceeds maximum protobuf size of 2GB", "string too long"]):
raise ValueError(err_large_model)
raise e

Expand Down