Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow composed relu6 with unknown dims #126

Merged
merged 2 commits into from
Sep 12, 2018
Merged

allow composed relu6 with unknown dims #126

merged 2 commits into from
Sep 12, 2018

Conversation

guschmue
Copy link
Collaborator

this should help #7, at least mobilenetv2 converts with this.

Copy link
Collaborator

@pengwa pengwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked Max/Min support broadcasting, so why we cannot use it directly?

@guschmue
Copy link
Collaborator Author

uh, true but only since opset8 ... I can add this for opset8.
But our runtime doesn't support this yet ... won't be able to test it.

@pengwa
Copy link
Collaborator

pengwa commented Sep 12, 2018

@guschmue I see. 囧😳

@guschmue
Copy link
Collaborator Author

added the code to make use of opset 8 if available. I'll test with opset 8 as soon the runtime supports it (soon). In the meantime there is no risk since we default to opset 7.

@guschmue guschmue merged commit 02bf716 into master Sep 12, 2018
@guschmue guschmue deleted the gs/relu6 branch September 12, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants