Enhance BatchToSpaceND and SpaceToBatchND handlers #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add explicit NHWC_TO_NCHW and NCHW_TO_NHWC transposes so they can be eliminated with its counterpart in TransposeOptimizer - handle nonconst pads and crops Signed-off-by: Mateusz Tabaka <mateusz.tabaka@intel.com>
|
Is this ready for review + merge? |
Yes |
TomWildenhain-Microsoft
suggested changes
Mar 10, 2021
| @@ -3323,7 +3323,7 @@ def func(x, z): | |||
|
|
|||
| @check_opset_min_version(11, "SpaceToBatchND") | |||
| def test_space_to_batchnd_non_const_7d(self): | |||
| x_type, y_type, z_type = np.int64, np.int64, np.int64 | |||
| x_type, y_type, z_type = np.float32, np.int64, np.int64 | |||
There was a problem hiding this comment.
The black_shapes include [2, 2] in this case, so it appears the code is properly tested.
Signed-off-by: Mateusz Tabaka <mateusz.tabaka@intel.com>
mateusztabaka
force-pushed
the
batchtospace
branch
from
f190a6a
to
cf9df39
Compare
TomWildenhain-Microsoft
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eliminated with its counterpart in TransposeOptimizer
Signed-off-by: Mateusz Tabaka mateusz.tabaka@intel.com