Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with adding more than one tf.newaxis at the same time #2007

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

southfreebird
Copy link
Contributor

This PR should solve a problem described in the issue: #1849

@fatcat-z
Copy link
Collaborator

fatcat-z commented Jul 22, 2022

Thanks for your contributions.
Please check the CI failures. Probably you should limit the min opset version for 2 test cases you added.

Signed-off-by: southfreebird <yvorott@gmail.com>

Co-authored-by: southfreebird <yvorott@gmail.com>
Co-authored-by: iolkhovsky <i.v.olkhovsky@gmail.com>
@southfreebird
Copy link
Contributor Author

It seems something wrong with python3.9 tests

@southfreebird
Copy link
Contributor Author

@fatcat-z
Could you help with tests please?
It seems something wrong with test_random_std_normal in python3.9 environment

@fatcat-z
Copy link
Collaborator

@fatcat-z Could you help with tests please? It seems something wrong with test_random_std_normal in python3.9 environment

Looking into it.

Copy link
Collaborator

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@fatcat-z fatcat-z merged commit 1c7d4ce into onnx:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants