map bfloat to float16 #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jignparm
reviewed
Apr 9, 2020
| s_ = tf.add(x_, y_) | ||
| return tf.cast(s_, tf.float32, name=_TFOUTPUT) | ||
| self._run_test_case(func, [_OUTPUT], {_INPUT: x_val, _INPUT1: y_val}) | ||
|
|
There was a problem hiding this comment.
Few questions below:
- is there a model that is unblocked by this?
- the test passes with small int values, but are there any values that will cause a failure?
|
Don't think we had a real model. But somebody was asking for it. |
guschmue
approved these changes
Apr 9, 2020
tf2onnx/tf_utils.py
Outdated
| @@ -32,6 +32,7 @@ | |||
| TF_TO_ONNX_DTYPE = { | |||
| types_pb2.DT_FLOAT: onnx_pb.TensorProto.FLOAT, | |||
| types_pb2.DT_HALF: onnx_pb.TensorProto.FLOAT16, | |||
| types_pb2.DT_BFLOAT16: onnx_pb.TensorProto.FLOAT, | |||
There was a problem hiding this comment.
You want that to be onnx_pb.TensorProto.FLOAT16 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map bfloat to float16 to address #735.