opset 12 support #897
Merged
opset 12 support #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guschmue
requested changes
Apr 24, 2020
jignparm
reviewed
Apr 24, 2020
jignparm
reviewed
Apr 24, 2020
guschmue
reviewed
Apr 24, 2020
guschmue
requested changes
Apr 25, 2020
guschmue
requested changes
Apr 28, 2020
jignparm
reviewed
Apr 28, 2020
| class Inverse: | ||
| @classmethod | ||
| def version_12(cls, ctx, node, **kwargs): | ||
| utils.make_sure(node.get_attr('adjoint').i == 0, "adjoint must be false") |
There was a problem hiding this comment.
Why "adjoint must be false"? Does this parameter simply mean we should compute the inverse of the adjoint of this matrix if set to true? It seems we should be able to handle "true" as well.
There was a problem hiding this comment.
Tested with inv(A) = adj(A)/det(A) approach, witnessed big diff. Will address adjoint case later.
guschmue
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for opset 12 ops.