Multiple fixes for Bert Model (fine-tuned) #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow output shape of (?,) Fix Squeeze op when tensor shape is (?,)
guschmue
reviewed
May 20, 2020
tf2onnx/tfonnx.py
Outdated
| try: | ||
| inputs = [] | ||
| skip = False |
There was a problem hiding this comment.
need the skip? we already check that all inputs are const below
There was a problem hiding this comment.
Thanks for the catch! inputs and len(op.input) == len(inputs) will only run if all are const. Removed the skip
guschmue
reviewed
May 20, 2020
tf2onnx/tfonnx.py
Outdated
| @@ -466,7 +460,7 @@ def compat_handler(ctx, node, **kwargs): | |||
| rewrite_single_direction_lstm, rewrite_bi_direction_lstm, | |||
| rewrite_single_direction_gru, rewrite_bi_direction_gru, | |||
| rewrite_custom_rnn_cell, rewrite_generic_loop, rewrite_cond, | |||
| rewrite_biasadd_with_conv2d, | |||
| rewrite_biasadd_with_conv2d, rewrite_constant_fold | |||
There was a problem hiding this comment.
might help to run const_cold first in the longer term but maybe more risk right now
There was a problem hiding this comment.
Moved it to first rewriter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for dynamic output shapes in Onnx model [ i.e. rank=1, shape =(?,)]
Fix 'Squeeze' op to handle shape of (?,)
Refactor 'Constant_folding' rewriter to pass unit tests