Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a tutorial for serving ONNX model with MXNet Model Server #36

Merged
merged 1 commit into from May 8, 2018

Conversation

lupesko
Copy link
Contributor

@lupesko lupesko commented May 5, 2018

An example showing how to take a pre-trained ONNX model (Squeezenet) and serve it for inference with MXNet Model Server.

@CLAassistant
Copy link

CLAassistant commented May 5, 2018

CLA assistant check
All committers have signed the CLA.

@lupesko
Copy link
Contributor Author

lupesko commented May 5, 2018

@jspisak @dzhulgakov please take a look.

@jspisak jspisak requested review from jspisak and houseroad May 8, 2018 04:22
Copy link
Contributor

@jspisak jspisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hagay, thanks for putting this together. I think this is a really good tutorial but a few things would make it even better:

  1. I would suggest using Netron or something else to visualize the onnx model. the .json isnt that pretty.
  2. Maybe suppress some of the synset? right now it is trying to render all 1000 category sets and i actually can't see the end of the tutorial because of this. Maybe just render the first 20 or 30?

Once you fix the synset issue I can then take a look at the rest of the tutorial.

@lupesko
Copy link
Contributor Author

lupesko commented May 8, 2018

Thanks for reviewing and suggesting improvements @jspisak , addressed your comments:

  • Removed the network print altogether, the important part there was to check the validity
  • Updated the synset print to only show top 10 lines

@jspisak
Copy link
Contributor

jspisak commented May 8, 2018

@lupesko - overall looks fine (although I havent tried it myself). is there a reason not to use Netron or some other lib to do a quick visualization of the net? If you dont want to use Netron, there is the one that James Reed wrote here

I can merge if you don't want to add this.

@lupesko
Copy link
Contributor Author

lupesko commented May 8, 2018

@jspisak let's merge for now. I can look into other visualization options later.
I like Netron, but it still does not have Jupyter notebook support (see this issue)

@jspisak
Copy link
Contributor

jspisak commented May 8, 2018

Got it, merging.. :)

@jspisak jspisak merged commit 6be9576 into onnx:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants