Implement an API for dictating the network architecture for tests #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adibrastegarnia
force-pushed
the
tests_api
branch
3 times, most recently
from
3151199
to
472fb6a
Compare
kuujo
reviewed
Sep 19, 2019
adibrastegarnia
force-pushed
the
tests_api
branch
3 times, most recently
from
9e9f870
to
61807ce
Compare
adibrastegarnia
force-pushed
the
tests_api
branch
4 times, most recently
from
111eead
to
9a3114a
Compare
|
Ready for your review. I still need to document the API itself but I will do it in another PR. This PR is already big enough :) I also added some tests (testapi) which shows how we can use the API to setup simulators, networks, apps. I will add more later. |
kuujo
requested changes
Sep 28, 2019
adibrastegarnia
force-pushed
the
tests_api
branch
from
4cf4db8
to
ce6088f
Compare
adibrastegarnia
force-pushed
the
tests_api
branch
from
ce6088f
to
52623ec
Compare
kuujo
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #7