Fix for SemanticVersionPreReleaseTag Number parsing #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"number" group that is larger then MaxInt.
|
Looping in @JakeGinnivan as I'm using the SemVer code from https://github.com/GitTools/GitVersion Jake, what do you think? |
|
Looks fine to me, if it is that big then it is not going to be an incrementing number so thats fine to lose it. On a side note I was thinking about pulling the SemVer classes from GitVersion out into a source only nuget package. Thoughts on that? |
|
A separate SemVer package would work for me (I'm ILMerge'ing everything in the project anyway) and it'd keep things more tidy. |
clairernovotny
pushed a commit
that referenced
this pull request
Oct 29, 2015
Fix for SemanticVersionPreReleaseTag Number parsing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for SemanticVersionPreReleaseTag Number parsing so that it can work with "number" group that is larger than MaxInt.