Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Calling convention needed on a few functions #182
I'm compiling my project with the __vectorcall calling convention (/Gv) on MSVC which causes doctest to throw up a few compile errors:
To fix them I had to add __cdecl to the functions fileOrderComparator, suiteOrderComparator, nameOrderComparator and main.
I'm only targetting Windows and Linux so this works for me, but I don't believe OS X supports the __cdecl calling convention, so my guess is that it is best to add a macro to specify the default calling convention for those methods.
I'm puzzled as to why there is a problem for
EDIT: actually microsoft state it in their docs about main... but instead of annotating it I'll just ignore the warning there
added a commit
Feb 4, 2019
@jrouwe actually I just moved away from
Try the dev branch and let me know if it's fixed. Not sure when I'll release this in the master branch though...