Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctest given defined with short macro name #239

Closed
m-bd opened this issue May 23, 2019 · 2 comments
Closed

doctest given defined with short macro name #239

m-bd opened this issue May 23, 2019 · 2 comments

Comments

@m-bd
Copy link
Contributor

m-bd commented May 23, 2019

It should be defined with the long name.
It is not defined otherwise (if no short macro names).

https://github.com/onqtam/doctest/blob/b6dbff7c5576a5f377caa7c5f53f01df3c479827/doctest/doctest.h#L2514
@onqtam
Copy link
Member

onqtam commented May 23, 2019

Thanks for catching this! I'll fix it at some point in the dev branch - burried in work currently. PRs welcome!

@m-bd
Copy link
Contributor Author

m-bd commented May 23, 2019 via email

m-bd pushed a commit to m-bd/doctest that referenced this issue May 23, 2019
fix doctest#239 - use long macro name
6171c88
m-bd added a commit to m-bd/doctest that referenced this issue May 23, 2019
@m-bd
fix doctest#239 - use long macro name
22ea25c
@m-bd m-bd mentioned this issue May 23, 2019
Merged
onqtam pushed a commit that referenced this issue May 28, 2019
@m-bd @onqtam
fix #239 - use long macro name (#240)
86fccdf
@onqtam onqtam closed this as completed in 64e3ddc Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-bd @onqtam