Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose ability to alias It, Describe, etc like gomega allows with by changing skip #377

Closed
gaffo opened this issue Sep 15, 2017 · 5 comments
Labels
v2 Issues that will be resolved by v2

Comments

@gaffo
Copy link

gaffo commented Sep 15, 2017

I have some wrapper functions It and Describe and I'd like them to show the correct context... but I can't access the Skip variable.

@gaffo
Copy link
Author

gaffo commented Oct 11, 2017

ping... per the contributing guide I wanted to discuss how to do this. I was considering exposing DescribeSkip, ItSkip, etc... but that seems somewhat clunky.

@gaffo
Copy link
Author

gaffo commented Oct 13, 2017

I think the more correct way would be to expose code point but that's more invasive

@pmzajaczkowski
Copy link

I have the same issue. I am writing some wrappers around It, Describe, etc. so my tests look better and to have standardized output in tests failure raport, but the links to the code location then points to my functions (wrappers) and not to tests - becuase of fixed skip value inside for example It(...) function. I'd like to have some functions like CustomIt(..., skip = 3) or to have access to the globalSuite so I can write similiar code as is in the body of It(...) but with different skip value.

@onsi onsi added v2 Issues that will be resolved by v2 and removed enhancement labels Apr 6, 2021
@onsi
Copy link
Owner

onsi commented Apr 6, 2021

I'm working through the backlog of old Ginkgo issues - apologies as this issue is probably stale now.

I'm going to address this as part of the v2 work - I'm going to make it possible to decorate tests with an Offset(N) to shift the line numbers up the call stack.

I'm going to close this for now, but feel free to reopen it if you'd like.

@onsi
Copy link
Owner

onsi commented Sep 10, 2021

A beta for Ginkgo V2 that fixes this issue was just released. Please try out the beta!

@onsi onsi closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Issues that will be resolved by v2
Projects
None yet
Development

No branches or pull requests

4 participants