Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors should be written to Stderr #471

Closed
stephanwesten opened this issue May 9, 2018 · 4 comments · Fixed by #610
Closed

Errors should be written to Stderr #471

stephanwesten opened this issue May 9, 2018 · 4 comments · Fixed by #610

Comments

@stephanwesten
Copy link

func (reporter *JUnitReporter) SpecSuiteDidEnd(...) writes errors to Stdout instead of Stderr. See:

fmt.Printf("Failed to create JUnit report file: %s\n\t%s", reporter.filename, err.Error())

and

fmt.Printf("Failed to generate JUnit report\n\t%s", err.Error())

@williammartin
Copy link
Sponsor Collaborator

Hey @stephanwesten seems like a sensible change to make. Is this causing you a problem? Would you be ok opening a PR?

@stephanwesten
Copy link
Author

Our Jenkins job ignores stdout and only captures stderr - this is why it is an issue. We work around it for now by also capturing stdout.

The bigger issue is that sometimes the junit file / report is not generated on Jenkins, no clue yet why.

@sowmiyamuthuraman
Copy link
Contributor

can I work on this?

@williammartin
Copy link
Sponsor Collaborator

Sure @sowmiyamuthuraman, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants