Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with documentation example of Les Miserables #782

Closed
elisarver opened this issue Mar 17, 2021 · 5 comments
Closed

Issue with documentation example of Les Miserables #782

elisarver opened this issue Mar 17, 2021 · 5 comments

Comments

@elisarver
Copy link
Contributor

I just want to write to say that the use of the Paperback Translation of Victor Hugo's Les Miserables resulted in a less than good number in the documentation site and the committed test that reflects the documentation.

Just coincidentally, I noticed that the number of pages, 1488 is also a dog whistle known as the fourteen words in Nazi/White Supremacist/Fascist circles.

The original version of the book was 2,783 pages long. It would be a simple substitution to make in the project. I'd do a pull request for the doc site, but I cannot find its source in the gh-pages branch.

@onsi
Copy link
Owner

onsi commented Mar 17, 2021

um. wow. had no idea! yeah please fix it - the docs live on the gh-pages branch!

@onsi
Copy link
Owner

onsi commented Mar 17, 2021

thanks for catching that and reporting it. i appreciate it!

@elisarver
Copy link
Contributor Author

elisarver commented Mar 17, 2021

Simple search/replace, luckily simple enough to fix. ;) (I didn't realize everything is in one big md file)

@onsi
Copy link
Owner

onsi commented Mar 17, 2021

All merged in now, thanks so much!

@williammartin
Copy link
Sponsor Collaborator

An interesting way to see if people read the documentation!

Thanks so much for the issue and PR calling this out. Going to close this since the PR was merged but feel free to reopen if you think there's more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants