ghttp Internal Server Error using NewWithT(t) and VerifyJSON

[macaptain]

If you set up a test using the ghttp server with NewWithT and NewGHTTPWithGomega, then use the VerifyJSON handler, the ghttp server responds with 500. (For more background, see #321 (comment) for an example of using ghttp with the XUnit style of tests calling NewWithT.)

Here's an example with github.com/onsi/gomega@v1.13.0:

package main

import (
	"bytes"
	. "github.com/onsi/gomega"
	"github.com/onsi/gomega/ghttp"
	"mime"
	"net/http"
	"testing"
)

func Test(t *testing.T) {
	g := NewWithT(t)
	gh := ghttp.NewGHTTPWithGomega(g)

	server := ghttp.NewServer()
	defer server.Close()

	server.AppendHandlers(
		ghttp.CombineHandlers(
			gh.VerifyRequest("POST", "/"),
			gh.VerifyJSON("{}"),
			gh.RespondWith(http.StatusCreated, "OK"),
		),
	)

	r, _ := http.Post(server.URL(), mime.TypeByExtension(".json"), bytes.NewBuffer([]byte("{}")))
	g.Expect(r.StatusCode).To(Equal(http.StatusCreated))
}

Running the test:

 $ go test
--- FAIL: Test (0.00s)
    main_test.go:28: 
        Expected
            <int>: 500
        to equal
            <int>: 201
FAIL
exit status 1

I expect the test to pass instead of fail.

What I think is happening is that the VerifyMimeType call in VerifyJSON is using the package level gomega instead of using the GHTTPWithGomega struct that's passed around.

gomega/ghttp/handlers.go

Line 134 in 9da0d13

VerifyMimeType("application/json"),

I think this call should be g.VerifyMimeType("application/json") to use the correct gomega.

I'm happy to submit a PR to fix this so that the verify receiver functions call other receiver functions. Let me know! 😃