New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Add, Or, Not, WithTransform matchers for composability. #108
Conversation
- Allows matchers to be composed into complex expressions that work even with the Eventually() assertion. - Also makes it easy to create new matchers -- can often write a function that composes a new matcher out of existing ones.
Thanks for the PRs! Am going to take a look and give them some thought and will get back to you soonz |
Hey @jim-slattery-rs this is good stuff - sorry for the delay, life has been busy! I have a few conversation points and suggestions. Am happy to work with you on all of this, too.
would become
Details are in the docs. I'd be happy to help with this.
|
- considers both Match() cases and considers the appropriate matcher(s) in making decision - also added a comment to WithTransform.MatchMayChangeInTheFuture(), as it will not have correct behavior with non-deterministic transformer
@onsi I think I've addressed all of your feedback!
I think that's everything for this PR, thanks for your feedback so far. I haven't updated the docs website yet, I take it that will be a separate PR on the gh-pages branch? Thanks, |
- simplify tests by using empty And() or Or() instead of Receive() with a closed channel
@jim-slattery-rs this looks good -- will pull it in and might make some cosmetic changes. A separate PR to the gh-pages branch would be great if you're up for it. Sorry for the long feedback loops - I'm finding I only have time to work on this over the weekends :/ |
Added Add, Or, Not, WithTransform matchers for composability.
Just stumbled over this, exactly what I needed and an awesome addition. Thanks for the effort @jim-slattery-rs |
Eventually()
assertion.types.GomegaMatcher
interface from scratch.