Add WithOffset methods to WithT type #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Douglass <mdouglass@pivotal.io> Signed-off-by: Jason Keene <jkeene@pivotal.io>
markdouglasswork
force-pushed
the
withoffset-witht
branch
from
daa3102
to
99e2ac5
Compare
|
We see that this PR is failing against the 'tip' release of Go. We noticed that in versions of Golang later than 1.9, we can use the 'Helper' function to achieve the desired results. We're going to close this PR and approach this using the 'Helper' function instead. |
|
I wouldn't worry about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an offset to be specified for
WithTmethods.There was not existing tests for the DSL so we didn't add any. ¯\_(ツ)_/¯