Bump go-yaml version to cover fixed ddos heuristic #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @petrkotas. Thank you for submitting this. I notice that |
go-yaml preceding 2.2.4 had vulnerability to ddos attack via billion laughs bomb. Such attack lead to program to be unresponsive. Signed-off-by: Petr Kotas <petr.kotas@gmail.com>
petrkotas
force-pushed
the
go-yaml-fix
branch
from
8a313ad
to
b2c4f44
Compare
|
Hi @blgm of course, sorry for that. Honestly I did not realised it is there since vscode keep adding this to my go.mod everywhere. |
|
Thank you @petrkotas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumbs go-yaml to v2.2.4, which has the ddos vulnerability fixed.
Issue:
go-yaml preceding 2.2.4 had vulnerability to ddos attack via billion laughs bomb.
Such attack lead to program to be unresponsive.
Issue has been described in https://raesene.github.io/blog/2019/10/15/From-stackoverflow-to-CVE/