New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid value for stunServers #117
Comments
It looks like we are translating the array of stun servers improperly when creating the media handler. The error shows up only when you attempt to place a call. For the lazy, here are statements that can reproduce the error:
|
@jwoertink, I wasn't able to reproduce your error in JSFiddle. Could you provide a code snippet that will (in either a browser or Node)? However, that fiddle did reproduce @wakamoleguy's error in Firefox. It looks like Firefox only allows String |
This avoids the following sort of situation, which Firefox (as of 33.0.2) has trouble with: var RTCPeerConnection = window.webkitRTCPeerConnection || window.mozRTCPeerConnection; new RTCPeerConnection({ 'iceServers': [{ "url": ["stun:stun.l.google.com", "stun:stun2.l.google.com"] }] }) addresses #117
hm... Yeah, I made a separate app to test it, and I can't reproduce it either. It must be something else in my app that conflicts and causing the issue. At least we got one issue solved! I'll close this out for now. |
This avoids the following sort of situation, which Firefox (as of 33.0.2) has trouble with: var RTCPeerConnection = window.webkitRTCPeerConnection || window.mozRTCPeerConnection; new RTCPeerConnection({ 'iceServers': [{ "url": ["stun:stun.l.google.com", "stun:stun2.l.google.com"] }] }) addresses onsip#117 (cherry picked from commit 28523b6)
I'm getting this issue again, but a little easier to debug. Using |
Hmm, I would have expected that to work, too. Since it didn't, I dug into the code and the relevant specs to find out why. Here's what I found: When you create the UA, it validates the |
oh wow. Yeah, that's the URI given by twilio for their new STUN/TURN service. Both the stun and trun uri's have a transport query param 😒 I'll see what they say about the specs to see if they are planning on changing that. |
Are you able to make calls using the STUN URI with the parameter removed? If so, I'd just go with that. EDIT: Note that TURN URIs can have the "transport" parameter and should work with the |
I do not believe we currently plan on supporting invalid STUN URLS. I'll close the issue, and it can be reopened if it looks like there is a compelling reason to tackle this. |
I'm getting an Invalid value error when trying to add an array of stunServers to my config. Using version 0.6.3.
http://sipjs.com/api/0.6.0/ua_configuration_parameters/#stunservers
The text was updated successfully, but these errors were encountered: