Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription.prototype.onDialogError is not defined #247

Closed
josephfrazier opened this issue Nov 6, 2015 · 0 comments · Fixed by #248
Closed

Subscription.prototype.onDialogError is not defined #247

josephfrazier opened this issue Nov 6, 2015 · 0 comments · Fixed by #248
Assignees
@josephfrazier

Comments

@josephfrazier
Copy link
Contributor

Using version 0.7.1, I see errors like this:

ERROR: uncaughtException: - TypeError: Object #<Object> has no method 'onDialogError'
    at Object.RequestSender.receiveResponse (sip.js/src/Dialog/RequestSender.js:71:22)
    at Object.RequestSender.receiveResponse (sip.js/src/RequestSender.js:133:22)
    at EventEmitter.NonInviteClientTransaction.receiveResponse (sip.js/src/Transactions.js:124:31)

I think we should define Subscription.prototype.onDialogError in the fashion of Session.prototype.onDialogError or DTMF.prototype.onDialogError (the other prototypes whose instances get passed to Dialog.RequestSender). Perhaps a this.ua.logger.error call and/or a failed event emission?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephfrazier josephfrazier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define Subscription.prototype.onDialogError to call this.failed josephfrazier/SIP.js
1 participant
@josephfrazier