New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge support #432

Open
chornyitaras opened this Issue Jul 15, 2017 · 16 comments

Comments

Projects
None yet
7 participants
@chornyitaras

chornyitaras commented Jul 15, 2017

Hello team,
I know about #223 . However latest release of Edge has all required API implemented. (for instance Janus Webrtc gateway works perfectly in Edge https://janus.conf.meetecho.com/echotest.html )

Are you planning to add Edge support in nearest future?

@egreenmachine

This comment has been minimized.

Show comment
Hide comment
@egreenmachine

egreenmachine Jul 17, 2017

Collaborator

We are looking into this as part of 0.8.0 which is looking like it will be mostly the work of #426. I have tested Safari, but have no tested Edge yet.

Collaborator

egreenmachine commented Jul 17, 2017

We are looking into this as part of 0.8.0 which is looking like it will be mostly the work of #426. I have tested Safari, but have no tested Edge yet.

@Klimashin

This comment has been minimized.

Show comment
Hide comment
@Klimashin

Klimashin Oct 13, 2017

Hi! Does Edge 15 supported now in version 0.8.1?

Klimashin commented Oct 13, 2017

Hi! Does Edge 15 supported now in version 0.8.1?

@egreenmachine

This comment has been minimized.

Show comment
Hide comment
@egreenmachine

egreenmachine Oct 13, 2017

Collaborator

Sorry I have not tested yet. You will almost certainly need to use the WebRTC adapter. If you get it to work or need specific changes, let us know and we can try and make it happen.

Collaborator

egreenmachine commented Oct 13, 2017

Sorry I have not tested yet. You will almost certainly need to use the WebRTC adapter. If you get it to work or need specific changes, let us know and we can try and make it happen.

@c960657

This comment has been minimized.

Show comment
Hide comment
@c960657

c960657 Oct 13, 2017

According to the release announcement, Microsoft Edge is supported in 0.8:
https://www.onsip.com/blog/sipjs-v0.8.0-supports-all-major-browsers-and-renegotiation

c960657 commented Oct 13, 2017

According to the release announcement, Microsoft Edge is supported in 0.8:
https://www.onsip.com/blog/sipjs-v0.8.0-supports-all-major-browsers-and-renegotiation

@egreenmachine

This comment has been minimized.

Show comment
Hide comment
@egreenmachine

egreenmachine Oct 13, 2017

Collaborator

I will have to have a discussion with our marketing team (hah). But I will honor their word and get some instructions for edge compatibility this afternoon. Stay tuned.

Collaborator

egreenmachine commented Oct 13, 2017

I will have to have a discussion with our marketing team (hah). But I will honor their word and get some instructions for edge compatibility this afternoon. Stay tuned.

@egreenmachine

This comment has been minimized.

Show comment
Hide comment
@egreenmachine

egreenmachine Oct 13, 2017

Collaborator

Microsoft edge works with the WebRTC adapter and SIP.js. Simply load the adapter before SIP.js on the DOM and SIP.js has everything it needs.

In my testing it appears that Edge is unhappy with SDP generated from anything that is not Edge. I am working on a base set of modifiers to get better compatibility with Edge.

Collaborator

egreenmachine commented Oct 13, 2017

Microsoft edge works with the WebRTC adapter and SIP.js. Simply load the adapter before SIP.js on the DOM and SIP.js has everything it needs.

In my testing it appears that Edge is unhappy with SDP generated from anything that is not Edge. I am working on a base set of modifiers to get better compatibility with Edge.

@aubalde

This comment has been minimized.

Show comment
Hide comment
@aubalde

aubalde Apr 9, 2018

Hi, when you plan to have a stable version with the modifiers?

aubalde commented Apr 9, 2018

Hi, when you plan to have a stable version with the modifiers?

@aubalde

This comment has been minimized.

Show comment
Hide comment
@aubalde

aubalde May 31, 2018

Hi all,

I'm testing SIP.js 0.9.2 with Edge v.41 including "adapter.js" before "SIP.js" and not works! The connection via web sockets is being disconnected continuously.

Any idea?

Thanks,

aubalde commented May 31, 2018

Hi all,

I'm testing SIP.js 0.9.2 with Edge v.41 including "adapter.js" before "SIP.js" and not works! The connection via web sockets is being disconnected continuously.

Any idea?

Thanks,

@JimGreenberg

This comment has been minimized.

Show comment
Hide comment
@JimGreenberg

JimGreenberg May 31, 2018

Collaborator

If you could post some logs of the issue, I might be able to point you in the right direction

Collaborator

JimGreenberg commented May 31, 2018

If you could post some logs of the issue, I might be able to point you in the right direction

@aubalde

This comment has been minimized.

Show comment
Hide comment
@aubalde

aubalde May 31, 2018

Hi Jim,

I am connecting to a FreeSWITCH server and every 30 seconds I get these traces in the Edge browser console after registration:

SCRIPT12030: WebSocket Error: Network Error 12030, The connection with the server was terminated abnormally.

Thanks,

aubalde commented May 31, 2018

Hi Jim,

I am connecting to a FreeSWITCH server and every 30 seconds I get these traces in the Edge browser console after registration:

SCRIPT12030: WebSocket Error: Network Error 12030, The connection with the server was terminated abnormally.

Thanks,

@JimGreenberg

This comment has been minimized.

Show comment
Hide comment
@JimGreenberg

JimGreenberg May 31, 2018

Collaborator

Based on only that- it seems like this is an issue with edge and websockets that isn't related to SIP.js at all. Without logs from FreeSWITCH or SIP.js I can't really be confident though- does it work in chrome?

Collaborator

JimGreenberg commented May 31, 2018

Based on only that- it seems like this is an issue with edge and websockets that isn't related to SIP.js at all. Without logs from FreeSWITCH or SIP.js I can't really be confident though- does it work in chrome?

@aubalde

This comment has been minimized.

Show comment
Hide comment
@aubalde

aubalde Jun 1, 2018

Hi JIm,

Yes, it works in Chrome and Firefox.

I've solved the problem with Edge periodically sending requests to web sockets to keep them active:
ua.request('NOTIFY', ext + '@eng2.presenceco.com');

Now, I've new errors and warnings:
WARNING: Timeout for addRemoteCandidate. Consider sending an end-of-candidates notification.
ERROR: ORTC18615: ORTC RTCDtlsTransport: error de protocolo de enlace DTLS. hr=c004e00f.

Any idea?

aubalde commented Jun 1, 2018

Hi JIm,

Yes, it works in Chrome and Firefox.

I've solved the problem with Edge periodically sending requests to web sockets to keep them active:
ua.request('NOTIFY', ext + '@eng2.presenceco.com');

Now, I've new errors and warnings:
WARNING: Timeout for addRemoteCandidate. Consider sending an end-of-candidates notification.
ERROR: ORTC18615: ORTC RTCDtlsTransport: error de protocolo de enlace DTLS. hr=c004e00f.

Any idea?

@JimGreenberg

This comment has been minimized.

Show comment
Hide comment
@JimGreenberg

JimGreenberg Jun 1, 2018

Collaborator

Sending those requests manually seems like something the keepAlive system should take care of- websockets can have their own system to keep the connection alive, but in the event of that not working/existing SIP.js has its keepAlive system that's configurable with the keepAliveInterval UA configuration option. I can't say with certainty that that would fix the issue, full logs would confirm.

Collaborator

JimGreenberg commented Jun 1, 2018

Sending those requests manually seems like something the keepAlive system should take care of- websockets can have their own system to keep the connection alive, but in the event of that not working/existing SIP.js has its keepAlive system that's configurable with the keepAliveInterval UA configuration option. I can't say with certainty that that would fix the issue, full logs would confirm.

@aubalde

This comment has been minimized.

Show comment
Hide comment
@aubalde

aubalde Jun 4, 2018

Hi Jim,

I've configured KeepAliveInterval to 20 (seconds) and it doesn't work. Every 30 seconds I've the same error reported 3 days ago.

SIP.js with Edge only works sending requests to web sockets to keep them active:
ua.request('NOTIFY', ext + '@eng2.presenceco.com');

Is there any open issue about this?

Thanks,

aubalde commented Jun 4, 2018

Hi Jim,

I've configured KeepAliveInterval to 20 (seconds) and it doesn't work. Every 30 seconds I've the same error reported 3 days ago.

SIP.js with Edge only works sending requests to web sockets to keep them active:
ua.request('NOTIFY', ext + '@eng2.presenceco.com');

Is there any open issue about this?

Thanks,

@ZikiBe

This comment has been minimized.

Show comment
Hide comment
@ZikiBe

ZikiBe Aug 2, 2018

Hi,

Can someone confirm that Edge is supported by the last version 0.11.2 ?

I'm trying to use it with the last adapter.js and I have the following error and no audio:

Timeout for addRemoteCandidate. Consider sending an end-of-candidates notification

Cyrille

ZikiBe commented Aug 2, 2018

Hi,

Can someone confirm that Edge is supported by the last version 0.11.2 ?

I'm trying to use it with the last adapter.js and I have the following error and no audio:

Timeout for addRemoteCandidate. Consider sending an end-of-candidates notification

Cyrille

@egreenmachine

This comment has been minimized.

Show comment
Hide comment
@egreenmachine

egreenmachine Aug 2, 2018

Collaborator

@ZikiBe can you provide full logs with traceSip enabled? There are a few ways that we can possibly make this better.

Collaborator

egreenmachine commented Aug 2, 2018

@ZikiBe can you provide full logs with traceSip enabled? There are a few ways that we can possibly make this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment