Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] config-based profiles #18

Closed
msbarry opened this issue Nov 7, 2021 · 3 comments · Fixed by #160
Closed

[FEATURE] config-based profiles #18

msbarry opened this issue Nov 7, 2021 · 3 comments · Fixed by #160
Assignees
@ZeLonewolf

Comments

@msbarry
Copy link
Contributor

msbarry commented Nov 7, 2021 •
edited

Right now you need to write Java code to build a custom profile. It might be nice if you could also write a json or yaml file that defines the logic and config for the profile.
@msbarry msbarry mentioned this issue Jan 9, 2022
Open
4 tasks
@ZeLonewolf
Copy link
Contributor

I am actively working on this using a YAML-based configuration language. Feel free to assign to me for tracking.

@wipfli
Copy link
Contributor

wipfli commented Apr 6, 2022

@ZeLonewolf can you open a draft pull request with what you have at the moment? I am curious to see where this goes...

@ZeLonewolf
Copy link
Contributor

@ZeLonewolf can you open a draft pull request with what you have at the moment? I am curious to see where this goes...

I will do that as soon as I get the code into a non-broken state :)

This was referenced Apr 8, 2022
Merged
Open
mmc1718 pushed a commit to nmr8acme/planetiler that referenced this issue Jan 24, 2023
@phanecak-maptiler
fix for issue onthegomap#18: adm0_l and adm0_r at z4 (onthegomap#53)
d378521 
* testCountryLeftRightName() extended to cover adm0_{l,r} not showing up at Z4

* fix for onthegomap#18 + alignment with OMT: adm0_{l,r} only for non-disputed and only from z5

* clean-up: if-else simplified since same for z4

* other tests updated to match adm0_{l,r} change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZeLonewolf ZeLonewolf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declarative schema from configuration file ZeLonewolf/planetiler
3 participants
@msbarry @ZeLonewolf @wipfli