-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offload multipolygon storage to disk (reduce memory usage by 10-15gb) #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/2025624986 ℹ️ Base Logs 313a695
ℹ️ This Branch Logs f80e6dd
|
Some stats from the -Xmx32g on a 64GB machine:
And it took 5.3 CPU-hours fetching way geometries From https://observablehq.com/@msbarry/planetiler-log-visualizer |
And some stats from the -Xmx206 on a 32GB machine:
And it took 12.1 CPU-hours fetching way geometries From https://observablehq.com/@msbarry/planetiler-log-visualizer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next biggest object held in memory after node locations is multipolygon way geometries. This was storing node IDs in an HPPC
LongLongMap
which makes a copy every time it expands. The list was getting up to 5-7GB, which requires an extra 5-7GB each time it expands. This change moves that to a more memory-efficientAppendStore
that doesn't require an extra 5-7GB memory to expand, and can also be offloaded to disk save another 5-7GB.I tested this out on the planet twice:
-Xmx32g
on a 16 cpu/64GB digitalocean droplet: finished in 2h19m (osm_pass2 took 1h36m)-Xmx20g
on a 16 cpu/32GB digitalocean droplet: finished in 2h58m (osm_pass2 took 2h5m)Checklist: