-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortbread schema #323
Merged
Merged
Shortbread schema #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/3112111160 ℹ️ Base Logs b934f4e
ℹ️ This Branch Logs 216469b
|
This reverts commit 412a15d.
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
1 similar comment
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass implementing the shortbread schema in planetiler using the new yaml config format. The schema itself is in
planetiler-custommap/src/main/resources/samples/shortbread.yml
and test cases for it are inshortbread.spec.yml
.This PR also includes adding new yaml config functionality required by shortbread:
quickstart.sh schema.yml
)__and__
__or__
and__not__
blocks, as well as matching any value for a key with__any__
and when a key is missing with''
value: ${ feature.tags['highway'].replace('_link', '') }
polygon_centroid
There are a few missing pieces called out as TODOs in shortbread.yml that will be addressed in followup PRs (tracked in #247):
Fixes #233, fixes #179