Fix data race #1259
Fix data race #1259
Conversation
consensus/vbft/block_pool.go
Outdated
|
|
||
| // clone a new block | ||
| newBlk := &Block{} | ||
| if err := newBlk.Deserialize(block.Serialize()); err != nil { |
There was a problem hiding this comment.
this looks too hacky, adding a new proposalSig field in blockProposalMsg to avoid data race.
There was a problem hiding this comment.
Right. But block signatures needs to be updated, and there'll be data race anyway.
You'll have to add lock to block header, or copy a new one.
There was a problem hiding this comment.
this update function is called when the blockPool's lock holds, I do not expect there is any data race left.
There was a problem hiding this comment.
No lock when reading signatures in block header, but signature array in block header must be updated.
Either adding locks for all read operations, or just clone a new one when updating then there'll no write ops to block header?
There was a problem hiding this comment.
blockpool's lock can not protect block headers in proposal message?
ヽ༼ຈʖ̯ຈ༽ﾉ
Honglei-Cong
force-pushed
the
fixDataRace
branch
from
bfbd3b9
to
db22601
Compare
No description provided.