fix log data race #1263
Merged
fix log data race #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +87,19 @@ func GetGID() uint64 { | |||
| return n | |||
| } | |||
|
|
|||
| var Log *Logger | |||
| var globalLogger unsafe.Pointer | |||
There was a problem hiding this comment.
validate pointer must not be nil after init?
There was a problem hiding this comment.
there is a init function to call InitLog, so can gurantee globalLogger will never be nil.
common/log/log.go
Outdated
| func InitLog(logLevel int, a ...interface{}) { | ||
| logger := createLog(logLevel, a...) | ||
|
|
||
| swapGlobalLogger(logger) |
There was a problem hiding this comment.
It's public.
check if old-logger is nil, close it if not nil?
| var Log *Logger | ||
| var globalLogger unsafe.Pointer | ||
|
|
||
| func Log() *Logger { |
There was a problem hiding this comment.
just a comment.
this function seems not necessary to be public.
There was a problem hiding this comment.
used in http rpc to set the log level.
|
looks good to me. |
Honglei-Cong
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.