ONT-776 decoupling peer id with wallet public key #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laizy
reviewed
Jun 13, 2018
| Version: n.GetVersion(), | ||
| Services: n.GetServices(), | ||
| SyncPort: n.GetSyncPort(), | ||
| ConsPort: n.GetConsPort(), | ||
| Nonce: n.GetID(), | ||
| IsConsensus: isCons, | ||
| HttpInfoPort: n.GetHttpInfoPort(), | ||
| StartHeight: uint64(height), | ||
| UserAgent: 0x00, | ||
| TimeStamp: uint32(time.Now().UTC().UnixNano()), |
There was a problem hiding this comment.
UnixNano? 1 second = 10^9 Nanosecond. so cast it to uint32 will get a value more like a random number.
laizy
reviewed
Jun 13, 2018
p2pserver/peer/peer.go
Outdated
| //parseIPAddr return ip address | ||
| func parseIPAddr(s string) (string, error) { | ||
| //ParseIPAddr return ip address | ||
| func (this *Peer) ParseIPAddr(s string) (string, error) { |
There was a problem hiding this comment.
this method has nothing to do with Peer, make it a free helper function for easier review.
laizy
reviewed
Jun 13, 2018
| } | ||
| ipNew, err := p.ParseIPAddr(data.Addr) | ||
| if err != nil { | ||
| log.Error(err) |
added 2 commits
June 13, 2018 16:33
…onnection Signed-off-by: Xiang Fu <fuxiang@onchain.com>
Signed-off-by: Xiang Fu <fuxiang@onchain.com>
laizy
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add logic to deny forge id connection
Signed-off-by: Xiang Fu fuxiang@onchain.com