fix remove connecting list bug #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2pserver/net/netserver/netserver.go
Outdated
| addrs = append(this.ConnectingAddrs[:i], this.ConnectingAddrs[i+1:]...) | ||
| for _, a := range this.ConnectingAddrs { | ||
| if strings.Compare(a, addr) != 0 { | ||
| addrs = append(addrs, a) |
There was a problem hiding this comment.
Why not use this.ConnectingAddrs = append(this.ConnectingAddrs[:i], this.ConnectingAddrs[i+1:]...), instead of using temp variable addrs ?
There was a problem hiding this comment.
Because if you change the this.ConnectingAddrs which is used for loop, it is dangerous. And in this case, it also can not remove duplicated elements.
There was a problem hiding this comment.
Ok. So please use addrs := this.ConnectingAddrs[:0] to avoid allocating a new underlying array
There was a problem hiding this comment.
btw: you can use if a != addr directly
There was a problem hiding this comment.
That's right, thanks all
Signed-off-by: chenzhijie <chenzhijie@onchain.com>
Signed-off-by: chenzhijie <chenzhijie@onchain.com>
laizy
approved these changes
Jun 19, 2018
BooniesFX
pushed a commit
to BooniesFX/ontology
that referenced
this pull request
Jun 20, 2018
Signed-off-by: chenzhijie <chenzhijie@onchain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chenzhijie chenzhijie@onchain.com