ONT-924 optimize transmit logic and the compatibility of dual/single port #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laizy
reviewed
Jun 21, 2018
p2pserver/link/link.go
Outdated
| nCount := nByteCnt / common.PER_SEND_LEN | ||
| for i := 0; i < nCount; i++ { | ||
| conn.SetWriteDeadline(time.Now().Add(common.WRITE_DEADLINE * time.Second)) | ||
| _, err = conn.Write(payload[i*common.PER_SEND_LEN : (i+1)*common.PER_SEND_LEN]) |
There was a problem hiding this comment.
any reason why need divided to n parts to call conn.Write instead one ?
There was a problem hiding this comment.
small package would be transmit more faster than write whole buffer under deadline and poor network environment
There was a problem hiding this comment.
It's the exact opposite of what I think.
laizy
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.