add preExecute in tx pool for non-consensus node #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laizy
reviewed
Jun 21, 2018
txnpool/proc/config.json
Outdated
| "ConsensusType":"solo" | ||
| { | ||
| "SeedList": [ | ||
| "polaris1.ont.io:20338", |
There was a problem hiding this comment.
this config file can be removed now?
lightshine001
force-pushed
the
master
branch
2 times, most recently
from
e0d79db
to
5dc7532
Compare
laizy
reviewed
Jun 25, 2018
txnpool/proc/txnpool_actor.go
Outdated
| @@ -64,6 +64,10 @@ type TxActor struct { | |||
| func (ta *TxActor) handleTransaction(sender tc.SenderType, self *actor.PID, | |||
| txn *tx.Transaction) { | |||
| ta.server.increaseStats(tc.RcvStats) | |||
| if len(txn.ToArray()) > 1024*1024 { | |||
…on size to prevent DOS attacks and check balance cover gas cost Signed-off-by: liupan@onchain.com <liupan@onchain.com>
laizy
reviewed
Jun 25, 2018
txnpool/proc/txnpool_actor.go
Outdated
| txn.Hash(), err) | ||
| } | ||
| if !isBalanceEnough(txn.Payer, result.Gas) { | ||
| return |
added 2 commits
June 25, 2018 17:46
Signed-off-by: liupan@onchain.com <liupan@onchain.com>
Signed-off-by: liupan@onchain.com <liupan@onchain.com>
tanZiWen
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.