ONT-927 optimize sync block msg send #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consensus/vbft/node_sync.go
Outdated
| @@ -400,7 +401,7 @@ func (self *PeerSyncer) requestBlock(blkNum uint32) (*Block, error) { | |||
| return nil, err | |||
| } | |||
| self.server.msgSendC <- &SendMsgEvent{ | |||
| ToPeer: self.peerIdx, | |||
| ToPeer: math.MaxUint32, | |||
There was a problem hiding this comment.
if only broadcasting support, consider fix this in self.server.msgSendC handling??
There was a problem hiding this comment.
yes. I will delete some unused code,like send to peer function.
xiemylogos
force-pushed
the
dev
branch
4 times, most recently
from
c98f48b
to
3b126ea
Compare
laizy
reviewed
Jun 26, 2018
consensus/vbft/peer_pool.go
Outdated
| @@ -266,3 +268,17 @@ func (pool *PeerPool) getPeer(idx uint32) *Peer { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (pool *PeerPool) addP2pId(peerIdx uint32, p2pId uint64) { | |||
| pool.lock.RLock() | |||
consensus/vbft/service.go
Outdated
| if !present { | ||
| self.peerPool.addP2pId(peerIdx, payload.PeerId) | ||
| } else { | ||
| if p2pid != payload.PeerId { |
There was a problem hiding this comment.
use if !present || p2pid != payload.PeerId
consensus/vbft/service.go
Outdated
| self.peerPool.addP2pId(peerIdx, payload.PeerId) | ||
| } | ||
| } | ||
| self.peerPool.addP2pId(peerIdx, payload.PeerId) |
laizy
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.