avoid data copy and buffer allocation when read out p2p message from network #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightshine001
previously approved these changes
Jul 26, 2018
Signed-off-by: laizy <laizhichao@onchain.com>
BooniesFX
suggested changes
Aug 27, 2018
p2pserver/link/link.go
Outdated
| "errors" | ||
| "fmt" | ||
| "net" | ||
| "time" | ||
|
|
||
| common2 "github.com/ontio/ontology/common" |
There was a problem hiding this comment.
use another name rather than "pkg+2"??
p2pserver/message/types/address.go
Outdated
| this.NodeAddrs = append(this.NodeAddrs, addr) | ||
| } | ||
|
|
||
| if count > comm.MAX_ADDR_NODE_CNT { |
There was a problem hiding this comment.
count exceed attack check should before node address appending
There was a problem hiding this comment.
- the param is not
[]byteany more, so all bytes belong to this message should be read out from thesource, to avoid subtle bug. 2. the max payload size has checked, so this is safe.
There was a problem hiding this comment.
so this is safe now, should we remove this count limit??
There was a problem hiding this comment.
since there is a global max outbound connection limit, the MAX_ADDR_NODE_CNT is to avoid malicious node send too many addresses and occupy the outbound connection?
p2pserver/message/types/address.go
Outdated
| } | ||
|
|
||
| //Deserialize message payload | ||
| func (this *Addr) Deserialize(r io.Reader) error { |
| this.P.Blk = append(this.P.Blk, hash) | ||
| } | ||
|
|
||
| if blkCnt > p2pCommon.MAX_INV_BLK_CNT { |
lightshine001
approved these changes
Aug 28, 2018
lightshine001
pushed a commit
to lightshine001/ontology
that referenced
this pull request
Sep 14, 2018
…network (ontio#566) Signed-off-by: laizy <laizhichao@onchain.com>
lightshine001
pushed a commit
to lightshine001/ontology
that referenced
this pull request
Sep 14, 2018
…network (ontio#566) Signed-off-by: laizy <laizhichao@onchain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: laizy laizhichao@onchain.com