add addresstobase58,base58toaddress API support #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laizy
reviewed
Sep 19, 2018
common/address.go
Outdated
| @@ -118,3 +105,24 @@ func AddressFromBase58(encoded string) (Address, error) { | |||
|
|
|||
| return ph, nil | |||
| } | |||
|
|
|||
| func VerifyBase58(encoded string) ([]byte, error) { | |||
There was a problem hiding this comment.
the original AddressFromBase58 has verified this, so any reason you need this function? and this implementation is buggy since the checksum is not verified.
There was a problem hiding this comment.
sorry, what's the meaning of 'buggy'
laizy
reviewed
Sep 20, 2018
common/address.go
Outdated
| } | ||
|
|
||
| buf := x.Bytes() | ||
| if len(buf) != 1+ADDR_LEN+4 || buf[0] != byte(23) { | ||
| return ADDRESS_EMPTY, errors.New("wrong encoded address") | ||
| } | ||
|
|
||
| if err != nil { |
tanZiWen
changed the title
laizy
reviewed
Oct 11, 2018
| Time: uint32(time.Now().Unix()), | ||
| Height: this.GetCurrentBlockHeight() + 1, | ||
| Tx: tx, | ||
| Time: header.Timestamp, |
laizy
previously approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.