optimize consensus code,modify return type when no error msg #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consensus/vbft/event_timer.go
Outdated
| @@ -190,7 +187,7 @@ func (self *EventTimer) getEventTimeout(evtType TimerEventType) time.Duration { | |||
| // | |||
| // internal helper, should call with lock held | |||
| // | |||
| func (self *EventTimer) startEventTimer(evtType TimerEventType, blockNum uint32) error { | |||
| func (self *EventTimer) startEventTimer(evtType TimerEventType, blockNum uint32) { | |||
There was a problem hiding this comment.
suggest changing the panic to 'return err'
xiemylogos
force-pushed
the
optimize_vbft
branch
from
cb50c3b
to
acebc4e
Compare
laizy
pushed a commit
to laizy/ontology
that referenced
this pull request
May 9, 2019
lucas7788
pushed a commit
to lucas7788/ontology
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.