Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude assertions #385

Merged
merged 12 commits into from Feb 28, 2019
Merged

Exclude assertions #385

merged 12 commits into from Feb 28, 2019

Conversation

beckyjackson
Copy link
Contributor

See #185

@jamesaoverton jamesaoverton modified the milestone: v1.3.0 Nov 5, 2018
@jamesaoverton jamesaoverton added this to the OBI milestone Dec 6, 2018
@jamesaoverton
Copy link
Member

I think this is not backwards compatible. Please merge the latest master and let's see what JAPICMP says.

@beckyjackson
Copy link
Contributor Author

mvn verify passes - could you point me to what you were worried about?

@jamesaoverton
Copy link
Member

Locally I tried copying the latest robot-core/pom.xml (with JAPICMP configuration updates) to this branch and running mvn verify. It failed with some JAPICMP compatility problems.

@beckyjackson
Copy link
Contributor Author

OK, I went back to ee2aec6 and it failed, but if you merge master into this branch, it passes... I think it's because new stuff got added in for 1.2.0, and this branch just wasn't up-to-date so it thinks stuff got removed.

@jamesaoverton
Copy link
Member

For OBI I just want the individuals that are used to define terms such as ‘curation status specification’. Could we add an option for --individuals definitions that includes only the individuals used in logical axioms?

@jamesaoverton jamesaoverton self-assigned this Feb 4, 2019
@jamesaoverton jamesaoverton mentioned this pull request Feb 22, 2019
Merged
@jamesaoverton
Copy link
Member

I'm happy with the feature and the code. Please resolve the conflicts and add some sort of unit test.

@jamesaoverton jamesaoverton merged commit b4b31f5 into ontodev:master Feb 28, 2019
@beckyjackson beckyjackson mentioned this pull request Mar 14, 2019
Closed
@beckyjackson beckyjackson deleted the exclude-assertions branch May 2, 2019 13:59
@jamesaoverton jamesaoverton mentioned this pull request Aug 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesaoverton jamesaoverton Awaiting requested review from jamesaoverton

Assignees

@jamesaoverton jamesaoverton

Labels
None yet
Projects
None yet
Milestone
OBI
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beckyjackson @jamesaoverton